Repository navigation
feat: Add default tags CLI option [K8SPCORE-1707] - #26
Merged
Miroslav Hlávka (mirozoe) merged 2 commits intoNov 26, 2025
Merged
Conversation
Miroslav Hlávka (mirozoe)
marked this pull request as ready for review
November 5, 2025 10:43
Miroslav Hlávka (mirozoe)
requested a review
from Alfred Krohmer (alfredkrohmer)
November 5, 2025 11:05
| *.swo | ||
| *~ | ||
|
|
||
| main |
Contributor
Author
There was a problem hiding this comment.
Yeah I mean compiled binary from main.go. But you are right, let's get rid off it.
Miroslav Hlávka (mirozoe)
force-pushed
the
fix/mirohl/K8SPCORE-1707-default-tags
branch
from
November 7, 2025 09:33
cac9d2a to
f959806
Compare
Ben (benarnold42)
approved these changes
Nov 7, 2025
Collaborator
There was a problem hiding this comment.
This doesn't incorporate the default tags. That means once an EIP is created, the default tags will not be applied retroactively if the CLI option is added afterwards. Is this intended?
Contributor
Author
There was a problem hiding this comment.
I think it should be addressed now.
Miroslav Hlávka (mirozoe)
force-pushed
the
fix/mirohl/K8SPCORE-1707-default-tags
branch
2 times, most recently
from
November 13, 2025 09:09
da05f43 to
06e0dfe
Compare
Miroslav Hlávka (mirozoe)
requested a review
from Alfred Krohmer (alfredkrohmer)
November 13, 2025 11:42
Miroslav Hlávka (mirozoe)
force-pushed
the
fix/mirohl/K8SPCORE-1707-default-tags
branch
from
November 20, 2025 14:15
06e0dfe to
12de404
Compare
Miroslav Hlávka (mirozoe)
force-pushed
the
fix/mirohl/K8SPCORE-1707-default-tags
branch
from
November 20, 2025 14:18
12de404 to
e11bcee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.