Repository navigation
Add Windows CI and declare update-artifact devDependencies - #1
Merged
Merged
Conversation
The verify script already requires js-yaml and @electron/asar, and Windows CI now typechecks, tests, builds, and audits production dependencies on every pull request and main push. Co-authored-by: Thana <gotzastory@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a CI workflow and declares the two packages
scripts/verify-update-artifacts.cjsalready requires..github/workflows/ci.ymlruns on pull requests and on pushes tomain.windows-latestand Node 22 because OpenPood is Windows-only (the release workflow already builds there). It runsnpm ci,npm run typecheck(both tsconfigs),npm test,npm run build, andnpm audit --omit=dev --audit-level=high.js-yaml@^4.3.2and@electron/asar@^3.4.1are now direct devDependencies. They were only transitive before, so a clean install did not guarantee the verify script couldrequirethem.This branch changes
package-lock.json. The later dependency PRs also change it frommain, so merge one lockfile PR at a time and rebase the others ontomainif they conflict.Branch protection
This workflow cannot turn on branch protection. After it is on
main, enable a protection rule formainthat requires the status check CI / Typecheck, test, and build before merging.Manual Windows check
No app behavior changes. The workflow itself is the check: confirm the Windows job is green on this PR. No packaged-app pass is required for this change.