Repository navigation
Fix host paste loop, cold-start HWND capture, and the OpenPood update feed - #2
Merged
Merged
Conversation
…OpenPood. A switch break was exiting the PowerShell loop, and a 300ms foreground race dropped the target before the host was ready. New builds also request gotzastory/OpenPood and pick up the Electron and fast-uri fixes. Co-authored-by: Thana <gotzastory@users.noreply.github.com>
…r-feed-b956 Co-authored-by: Thana <gotzastory@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the dictation host so a declined paste does not kill PowerShell, waits for a cold host before giving up on the foreground window, and points new builds at
gotzastory/OpenPood.electron/winHost.ts,clipboard-changedandfocus-changedno longer usebreakinside theswitchthat sits inwhile ($true). In PowerShell thatbreakexits the host loop, so the reply is never flushed and the process ends. The host now writes the reply and falls through toFlush(). The only remainingbreakis end-of-stdin. Covered byelectron/winHost.test.tswithout launching PowerShell.pasteAtCursorreturnstarget-unknownand does not write the clipboard until the HWND is a real window. The transcript stays in History.electronis^43.8.7(latest 43.x, includes the 43.8.1 fix for GHSA-jr5w-w6x2-84p9).electron-updateris6.8.11.fast-uriis overridden to3.1.9(the parent range is^3.0.1, so this is not a major bump).build.publish.repo,UPDATE_FEEDinelectron/updater.ts(setFeedURL), and the README release links now saygotzastory/OpenPood.This branch changes
package-lock.jsonfrommainon its own. The CI and dev-dependency PRs do too. Merge one lockfile change at a time and rebase the others ontomainif they conflict.Already-installed v1.0.3
Installed v1.0.3 builds have
gotzastory/OpenPudbaked intoapp-update.yml. They keep working only because GitHub redirects the renamed repository. Do not create a new repository or fork namedOpenPud. A new repo with that name would capture those update checks.Tests
npm test(159) andnpm run build(both tsconfigs, then Vite) passed here. New cases cover the host script, a slow HWND lookup, a failed-then-retried lookup, and leaving the clipboard alone when the HWND is unknown.Manual Windows check
gotzastory/OpenPoodreleases, notOpenPud.