Skip to content

feature / SSD-188 / splask multilang support - [Select] #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harrisazmi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feature / SSD-188 / splask multilang support - [Select] #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/orange-jobs-dance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@govtechmy/myds-react": patch
---

Integration of Splask Multilang Support to select component
42 changes: 28 additions & 14 deletions packages/react/src/components/select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ type SelectBase = Omit<
> & {
variant: "outline" | "ghost" | null;
size: "small" | "medium" | "large" | null;
/**
* Add this prop for Splask Multilang Support
* Will render splwpk-multilang ="splwpk-multilang"
*/
splaskMultilang?: boolean;
};

type SelectSingle = SelectBase & {
Expand Down Expand Up @@ -96,20 +101,29 @@ const Select: React.ForwardRefExoticComponent<SelectProps> = React.forwardRef(
};

return (
<SelectContext.Provider
value={{ ...props, _value, _handleClose: _setOpen }}
>
<SelectPrimitive.Root
ref={ref}
{...props}
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
/* @ts-expect-error */
value={_value}
onValueChange={handleValueChange}
open={_open}
onOpenChange={handleClose}
/>
</SelectContext.Provider>

<div
{...(props.splaskMultilang
? { "splwpk-multilang": "splwpk-multilang" }
: {})}
>
<SelectContext.Provider
value={{ ...props, _value, _handleClose: _setOpen }}
>
<SelectPrimitive.Root
ref={ref}
{...props}
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
/* @ts-expect-error */
value={_value}
onValueChange={handleValueChange}
open={_open}
onOpenChange={handleClose}
/>
</SelectContext.Provider>
</div>


);
},
);
Expand Down