Repository navigation
Fix HTML parsing errors - #3271
Merged
Merged
Conversation
DavidBiddle
marked this pull request as ready for review
October 30, 2026 17:00
DavidBiddle
force-pushed
the
fix-HTML-parsing-errors
branch
from
October 30, 2026 17:00
e80a89b to
a368eab
Compare
lfdebrux
reviewed
Nov 2, 2026
lfdebrux
reviewed
Nov 2, 2026
lfdebrux
force-pushed
the
fix-HTML-parsing-errors
branch
from
November 2, 2026 11:39
a368eab to
258d17d
Compare
lfdebrux
enabled auto-merge
November 2, 2026 11:40
SamJamCul
approved these changes
Nov 2, 2026
In a couple of places we had `target="_blank""` with an accidental double `""` at the end, which is invalid HTML.
We were missing a space after the `lang` attribute, which is invalid HTML.
The closing tags on these `dd` elements were in the wrong place, causing nested `dd` elements, which is invalid HTML. This commit corrects the closing tag placement so that the `govuk-summary-list__value` and `govuk-summary-list__actions` items are separate `dd` elements
lfdebrux
force-pushed
the
fix-HTML-parsing-errors
branch
from
November 2, 2026 12:45
258d17d to
137f8ab
Compare
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-3271.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card:
Resolves a few bits of invalid HTML.
I don't think these are likely to have caused any real issues for users (browsers are pretty good at handling malformed HTML and I didn't spot any visual problems).
See individual commit messages for details.
Things to consider when reviewing