Skip to content

Remove stale SNS topic ARN from deployer policy - #2373

Merged
theseanything merged 1 commit into
mainfrom
remove-stale-ses-sns-topic-arn
Nov 3, 2026
Merged

theseanything merged 1 commit into
mainfrom
remove-stale-ses-sns-topic-arn

Conversation

@theseanything

@theseanything theseanything commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

Trello card: https://trello.com/c/BCDU9U7N/3456-remove-sesbouncesandcomplaints-sns-resource-if-all-environments-are-using-the-new-queues

The deployer policy still lists the ses_bounces_and_complaints SNS topic. Terraform stopped creating it when 4d97448 renamed it to auth0_ses_bounces_and_complaints in September 2025, so the deployer no longer needs permissions on the old name.

In production the topic no longer exists, and no SES configuration set, subscription, alarm or EventBridge rule refers to it.

Terraform stopped creating this topic when 4d97448 renamed it to
auth0_ses_bounces_and_complaints, so the deployer no longer needs
permissions on the old name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 30, 2026 14:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Dev and staging migration state remains unverified, so Terraform may still need the permissions being removed to delete the legacy SNS topic.

No open issues 🎉

What changed in this PR

Removes the legacy ses_bounces_and_complaints SNS topic ARN from the deployer policy following its rename to auth0_ses_bounces_and_complaints.

Changes:

  • Removes the obsolete permission entry and its cleanup TODO, leaving permissions for the current SNS topics unchanged.
File Description
infra/​modules/​deployer-access/​policy.tf Removes the legacy SNS topic ARN from the deployer policy.

Review effort: Balanced

@theseanything
theseanything requested a review from whi-tw November 3, 2026 11:46
@theseanything
theseanything added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit 0673875 Nov 3, 2026
25 checks passed
@theseanything
theseanything deleted the remove-stale-ses-sns-topic-arn branch November 3, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants