[DavidBiddle]

What problem does this pull request solve?

Trello card: https://trello.com/c/P7bDQZTP/3248-get-submission-delivery-configuration-from-latest-live-version-of-the-form-in-forms-runner

Updates the batch submission processing logic to always fetch the latest delivery configurations from the delivery configurations endpoint in forms-admin, instead of checking the form document attached to the submission as we do currently.

Note: govuk-forms/forms-admin#3239 needs to be deployed before this can be merged

Things to consider when reviewing

• Ensure that you consider the wider context.
• Does it work when run on your machine?
• Is it clear what the code is doing?
• Do the commit messages explain why the changes were made?
• Are there all the unit tests needed?
• Do the end to end tests need updating before these changes will pass?
• Has all relevant documentation been updated?

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Copilot]

🟡 Changes recommended

Batch selection introduces per-submission HTTP requests, and lookup failures can leave orphaned submissions.

2 open findings

• Deduplicate form lookups before loading daily submissions · New
• Prevent orphaned submissions when configuration lookup fails · New

🧠 Review effort: Balanced

[Copilot]

🟡 Changes recommended

Batch scheduling reliability, query scalability, and partial-delivery cleanup need correction before approval.

5 open findings

• Retry transient lookup failures to prevent permanent scheduling gaps · New
• Avoid destroying submissions after partial delivery enqueue failures · New
• Deduplicate form and mode pairs in PostgreSQL, not Ruby · New
• Deduplicate form lookups before loading daily submissions
• Test delivery creation uses endpoint configuration over stale document data · New

1 resolved since last review

• Prevent orphaned submissions when configuration lookup fails

🧠 Review effort: Balanced

[DavidBiddle]

I've moved the immediate submission handling into #2435, so this PR will only cover the changes to batch submissions.

[DavidBiddle]

I've now reworked this to get the list of forms with batch delivery enabled from forms-admin, instead of looking it up per-form. To do this I've added a new endpoint to forms-admin: govuk-forms/forms-admin#3239

[github-actions]

🎉 A review copy of this PR has been deployed! It is made of up two components

1. A review copy of forms-runner
2. A production copy of forms-admin

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.