PP-15812 Fix Adyen payment normalisation error - #4106
Merged
Merged
Conversation
Fix error normalising entered payment data when making an Adyen payment introduced by commit 81c1c66. The error was caused by the client-side JavaScript adding a duplicate hidden form field with the name jsEnabled, which Node.js handles by combining the two values into an object, which means it’s not a string when later code tries to trim it. Fix the problem by making sure that there is only one jsEnabled hidden form field (or js_enabled JSON property in the case of Google Pay payments). Enhance the existing Cypress test that tests these hidden form fields by making it submit the form to ensure they’re actually processed correctly on the server side. Co-authored-by: Gabriel Boardman <gabriel.boardman@madetech.com> Co-authored-by: Hugo Jeffreys<hjvoid@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix error normalising entered payment data when making an Adyen payment introduced by commit 81c1c66.
The error was caused by the client-side JavaScript adding a duplicate hidden form field with the name
jsEnabled, which Node.js handles by combining the two values into an object, which means it’s not a string when later code tries to trim it.Fix the problem by making sure that there is only one
jsEnabledhidden form field (orjs_enabledJSON property in the case of Google Pay payments). Enhance the existing Cypress test that tests these hidden form fields by making it submit the form to ensure they’re actually processed correctly on the server side.