This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Open
Conversation
awaitAndDownloadApps returns a promise which polls status for build id, and when platform builds are complete, downloads them. The promose resolves when all builds are successfully downloaded, and rejects if an error is encountered along the way (in getStatus polling, an error in the build, or in a download).
goya
force-pushed
the
master
branch
8 times, most recently
from
4d84043 to
851c01e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: phonegap-build#3
So I went ahead and worked out a more complete solution polling for build status and then download - I was interested in the problem, and wanted to try out the jest testing framework you are using (which I'm liking, once I figured out that it was configured such that I needed to write the test to pump setTimeout() by hand). I'm not sure if the PR should be to goya/pgb-api or phonegap-build/pgb-api
Here's where I got to - feel free to adopt / reject / mutate or whatever :)
awaitAndDownloadApps returns a promise which polls status for build id,
and when platform builds are complete, downloads them. The promose resolves when all builds are successfully downloaded, and rejects
if an error is encountered along the way (in getStatus polling, an error in the build, or in a download)