Repository navigation
Stream plain answer text as it arrives - #22
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a0b5f9780
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const privateMarker = text.search(/[\uE000-\uF8FF]/); | ||
| if (privateMarker >= 0) boundary = Math.min(boundary, privateMarker); | ||
| return boundary; |
There was a problem hiding this comment.
Hold unfinished Markdown links before emitting their labels
When an upstream snapshot ends with Here is [report]( and a later snapshot appends sandbox:/mnt/data/report.csv), this helper emits the entire first snapshot because it contains no recognized marker. Once the destination arrives, renderRichOutput replaces the whole Markdown link with Download file: [report.csv](...), including the already-emitted label. Consequently, remainingStreamText throws Upstream changed text already delivered to the client, terminating both Chat Completions and Responses streams instead of delivering the download. The previous bracket guard prevented this case; retain unfinished link syntax until its destination is known rather than buffering only the pointer prefix.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary
Validation
Summary by CodeRabbit