https://github.com/oracle/graal/issues/11050 - #869
Conversation
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
Bot
added
the
OCA Required
|
Hello team, I also find this feature request interesting. Could you please help review my code? Thank you |
|
This looks good at first. Can you please complete the PR title and description. Explain how the new feature is working, what is changed, is it enabled by default, etc. We also need to rebase this PR as we are now spec-driven. |
|
Please improve the PR title and add a short description of the change. |
| return stream | ||
| .filter(Files::isRegularFile) | ||
| .filter(NativeBuildReportMojo::isHtmlFile) | ||
| .max(Comparator.<Path>comparingInt(path -> buildReportScore(path, imageName)) |
There was a problem hiding this comment.
Could we filler out candidates whose score is zero?
Any unrelated HTML file in target/ is selected when no actual build report exists, so the Maven site could list the wrong page instead of none.
| } | ||
|
|
||
| @Override | ||
| public String getOutputName() { |
There was a problem hiding this comment.
Since this is a Maven report path rather than a filesystem path, should this use / instead of File.separator for Windows compatibility?
There was a problem hiding this comment.
Also, as this uses Reporting API 4, it may also be preferable to implement getOutputPath (since getOutputName is deprecated?).
|
@junietrytwo any update on this PR? |
3 participants
oracle/graal#11050