Repository navigation
ci: align with github-actions-playbook v1.9 - #148
Merged
Merged
Conversation
- Switch from dtolnay/rust-toolchain to the pinned actions-rust-lang/setup-rust-toolchain v2.0.0 (with cache: false, caching stays on the explicit actions/cache steps), replacing the targets input with target where needed. - Remove .github/zizmor.yml: the superfluous-actions suppressions applied only to dtolnay/rust-toolchain, which zizmor no longer flags after the switch. - Update .github/poutine.yml unverified-creator skip list. - Reverse the Homebrew tap order: trust the tap before tapping it.
Nightly cargo emits cargo::unused_dependencies for the [build-dependencies] (clap, clap_complete — completion generation has lived in the binary since the generate-completion subcommand) and cargo::redundant_homepage for the homepage field duplicating repository. setup-rust-toolchain defaults to build-warnings: deny, so these manifest warnings failed CI on nightly and beta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the CI workflows with github-actions-playbook v1.9, up from v1.7. The
v1.8 self-repository
uses:syntax was already in place, so what remains isthe v1.9 toolchain switch and the v1.8 Homebrew tap ordering.
Replaces
dtolnay/rust-toolchainwith the pinnedactions-rust-lang/setup-rust-toolchainv2.0.0 in ci-essentials, thecompatibility matrix, the cargo-audit reusable workflow, and the release
workflow, with
cache: falseso the explicitactions/cachesteps stay incharge of caching (
targets:becomestarget:on the cross-build jobs). Thatswitch makes the zizmor
superfluous-actionssuppressions moot, so.github/zizmor.ymlis removed and the poutine skip list now names the newaction. The Homebrew job also runs
brew trust --tapbeforebrew tap, sothe tap is trusted before Homebrew evaluates it.
The new action defaults to
build-warnings: deny, which turned two freshcargo manifest warnings into CI failures on nightly and beta: the
[build-dependencies]onclapandclap_completeare dead (completiongeneration has lived in the binary since the
generate-completionsubcommand), and
homepageduplicatesrepository. Both are dropped fromCargo.toml(Cargo.lockis unaffected — the crates remain as regulardependencies).
Verified with
make ci-security(poutine and zizmor clean) andmake md; thepinned SHA matches the upstream v2.0.0 tag, and nightly clippy passes locally
with
CARGO_BUILD_WARNINGS=deny.