-
Notifications
You must be signed in to change notification settings - Fork 707
Fixing prom v3 upgrade issues #4044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c8749a4
aae2e79
8316a6c
ee6477c
cdbd30f
9e418f0
1bd9e30
441d86b
56d8c6c
3d1abf3
4959cb0
ecf7f84
5415887
51cd328
662e2c1
ed5aa4c
5b13b8a
bcc083a
ad515c0
a416031
f702784
6d058d2
e8c8ea0
36dd009
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,29 @@ | ||
| logging { | ||
| level = "debug" | ||
| } | ||
|
|
||
| livedebugging {} | ||
|
|
||
| prometheus.scrape "scrape_prom_metrics" { | ||
| targets = [ | ||
| {"__address__" = "prom-gen:9001"}, | ||
| ] | ||
| forward_to = [prometheus.remote_write.scrape_prom_metrics.receiver, otelcol.receiver.prometheus.scrape_prom_metrics_to_otlp.receiver] | ||
| forward_to = [prometheus.write.queue.scrape_prom_metrics.receiver, otelcol.receiver.prometheus.scrape_prom_metrics_to_otlp.receiver] | ||
| scrape_classic_histograms = true | ||
| scrape_protocols = ["PrometheusProto", "OpenMetricsText1.0.0", "OpenMetricsText0.0.1", "PrometheusText0.0.4"] | ||
| scrape_native_histograms = true | ||
| scrape_interval = "1s" | ||
| scrape_timeout = "500ms" | ||
| } | ||
|
|
||
| prometheus.remote_write "scrape_prom_metrics" { | ||
| endpoint { | ||
| url = "http://mimir:9009/api/v1/push" | ||
| send_native_histograms = true | ||
| metadata_config { | ||
| send_interval = "1s" | ||
| prometheus.write.queue "scrape_prom_metrics" { | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As a follow up, I want to expand our integration tests to cover more cases and protocols and use old remote_write component too. But for now we should switch to the one we use most commonly: new WAL with (mostly) default settings. The only settings we're giving here are to make the test go faster. |
||
| endpoint "mimir" { | ||
| url = "http://mimir:9009/api/v1/push" | ||
| flush_interval = "1s" | ||
| batch_count = 10 | ||
| external_labels = { | ||
| test_name = "scrape_prom_metrics", | ||
| } | ||
| } | ||
| queue_config { | ||
| max_samples_per_send = 100 | ||
| } | ||
| } | ||
| external_labels = { | ||
| test_name = "scrape_prom_metrics", | ||
| } | ||
| } | ||
|
|
||
| otelcol.receiver.prometheus "scrape_prom_metrics_to_otlp" { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell we use
fix-corrupted-name-labelin your fork, that includes the staleness fix. Are we planning to use your fork here or is this only temporary?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is temporary while we get this fix prometheus/prometheus#16957 merged upstream. I mentioned on Slack, sorry if you missed this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to merge the PR as long as we don't release the next version with this fork.