fix(loki.source.docker): Preserve positions for stopped containers - #7040
Open
al1re3a wants to merge 1 commit into
Open
fix(loki.source.docker): Preserve positions for stopped containers#7040al1re3a wants to merge 1 commit into
al1re3a wants to merge 1 commit into
Conversation
|
|
Contributor
|
This would break some behavior we have right now, if a target is removed then we would keep the position with this pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description of Pull Request
Preserve Docker log positions when a container stops but still exists, so restarting the container resumes from the stored cursor instead of replaying retained logs.
Pull Request Details
loki.source.dockernow inspects a target after its tailer stops. It removes the stored position only when Docker reports that the container is not found; stopped containers and transient inspection failures keep their positions. Tests cover stopped, removed, inspection-error, and component-shutdown paths.Issue(s) fixed by this Pull Request
Fixes #7036
Notes to the Reviewer
PR Checklist