Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description of Pull Request
This PR will add support to receive Pushgateway-compatible metrics through a separate :9999 port (configurable) which allows Alloy to replace the current single-functionality of Prometheus Pushgateway.
Pull Request Details
I am currently using Alloy as the sole ingestor of metrics, logs, and traces on all my infrastructures and I needed to replace the Pushgateway with what's already a feature-complete product, that is Alloy.
This PR is going to serve myself first, and perhaps a bunch of other folks waiting for it in its respective GH issue.
I considered having it as an opt-in/beta feature but it is small enough to be rolled out on its own, since it's not a breaking functionality to the
prometheus.receive_httpat the moment.Issue(s) fixed by this Pull Request
fixes #3493
Notes to the Reviewer
I ran the example end-to-end locally with the setup present in the current PR under
example/pushgateway.PR Checklist
Expand to see the updated rendered doc