Skip to content

refactor(otelcol): Seed factory defaults where Alloy already assigns them (group 2 of 5) - #7085

Open
kgeckhart wants to merge 1 commit into
mainfrom
kgeckhart/otel-defaults-group2
Open

kgeckhart wants to merge 1 commit into
mainfrom
kgeckhart/otel-defaults-group2

Conversation

@kgeckhart

Copy link
Copy Markdown
Contributor

Brief description of Pull Request

Group 2 of 5 of the upstream-defaults sweep. Seed the wrapped config from the component factory's default instead of a zero struct in five otelcol components. Their upstream defaults are non-empty, unlike group 1's, but Alloy already assigns every one of them, so this batch also changes no behavior.

Issue(s) fixed by this Pull Request

Related to #6866

PR Checklist

  • Documentation added
  • Tests updated
  • Config converters updated
  • This pull request was substantially generated with AI assistance (see the GenAI policy)

@kgeckhart
kgeckhart requested a review from a team as a code owner September 10, 2026 20:56

@kalleep kalleep left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add tests to verify default config.

When we update it will be much easier to detect breaking changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants