Conversation
…them (group 2 of 5)
kalleep
reviewed
Sep 14, 2026
kalleep
left a comment
Contributor
There was a problem hiding this comment.
I think we should add tests to verify default config.
When we update it will be much easier to detect breaking changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description of Pull Request
Group 2 of 5 of the upstream-defaults sweep. Seed the wrapped config from the component factory's default instead of a zero struct in five
otelcolcomponents. Their upstream defaults are non-empty, unlike group 1's, but Alloy already assigns every one of them, so this batch also changes no behavior.Issue(s) fixed by this Pull Request
Related to #6866
PR Checklist