Conversation
Contributor
|
💻 Deploy preview deleted (fix(loki.write): Don't hang on shutdown when the send queue is full). |
4 tasks
Contributor
Author
|
Replaced by #7091 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description of Pull Request
Let
loki.writeshut down while an endpoint's send queue is full.Pull Request Details
Stopwaited on the goroutine feedingendpoint.enqueuebefore releasing it, so a full queue deadlocked shutdown and config reloads. Blocked writes now getdrain_timeoutto find room before they're dropped. Also corrects three arguments on the reference page whose documented defaults and behavior disagreed with the code.PR Checklist