fix(loki.write): WAL writer metrics is now collected after reload - #7093
Merged
Merged
Conversation
kalleep
changed the title
thampiotr
reviewed
Sep 14, 2026
Contributor
There was a problem hiding this comment.
I think the tests are not able still to discover this as a bug. Would it be possible to add a check for this?
kalleep
force-pushed
the
kalleep/fix-loki-wal-writer-metrics
branch
from
September 14, 2026 13:30
a59e228 to
8e02a5e
Compare
kalleep
force-pushed
the
kalleep/fix-loki-wal-writer-metrics
branch
from
September 14, 2026 13:31
8e02a5e to
5ab1b95
Compare
thampiotr
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description of Pull Request
Fix WAL writer metrics after config reload.
Pull Request Details
Writer metrics was registered with
reg.Register. This one will return an error if we have already registered these metrics before, but the code ignored this error.Because of that writer would update metrics that was not collected anymore after a reload happened. I changed it to accept a metrics struct instead to match other code here and use our util function when registering the metric.
Issue(s) fixed by this Pull Request
Part of: #7094
Notes to the Reviewer
PR Checklist