Cue: Enums as map index#1081
Open
spinillos wants to merge 7 commits into
Open
Conversation
|
Note: the diff show code changes that would be introduced by this PR to the output of the Grafana Foundation SDK codegen pipeline.
|
IfSentient
reviewed
Apr 28, 2026
IfSentient
left a comment
IfSentient
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just one note about the CUE issue in the go comments
| // It first tries v.Syntax() (the CUE Def export), but falls back to v.Source() | ||
| // when Syntax() returns a *ast.BadExpr — which happens for enum-indexed maps | ||
| // due to a CUE exporter bug: "reference in label expression refers to field | ||
| // against which it would be matched" (see https://cuelang.org/issues/new). |
Contributor
There was a problem hiding this comment.
The comment just refers to the open a new issue page in the cue repo, I think it should be referring to cue-lang/cue#4291, though I may have found the wrong issue searching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #893