Conversation
awsome-o
marked this pull request as ready for review
September 11, 2026 20:07
awsome-o
force-pushed
the
codex/guidance-consistency
branch
from
September 14, 2026 19:23
daaecb6 to
91ca7fa
Compare
An agent reading AGENTS.md, a contributor skill, or a design doc could get instructions that no longer match the repository. The worktree bootstrap promised an automatic download that only fires for one host and invoked a bare go. The command list claimed race detection the test tasks do not run. The release task was described as tagging when it prepares a release branch and prints the tagging commands. Several skills named commands that no longer exist, and the concurrency and auth descriptions documented behavior the code had already moved past. This corrects those statements against the current implementation and fixes two broken links, the missing ADR-006 file reference and a dead ARCHITECTURE.md anchor in VISION.md. The observability skill now orders review and remediation before export, so the exported state reflects any authorized remediation, and it carries fallbacks for hosts without Claude-style task tools. No runtime behavior changes; the Go edit is a comment. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
awsome-o
force-pushed
the
codex/guidance-consistency
branch
from
September 14, 2026 19:42
91ca7fa to
5546bfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
An agent starting from
AGENTS.md, a contributor skill, or a design doc can get instructions that no longer match this repository. This corrects those statements against the code, in 29 files, +201/−177. No runtime behavior changes: the single Go edit is a comment.This is the first of four slices carved out of the original #1318 (50 files, +1087/−795). The others cover CLI contracts, provider migration, and review publication. Nothing here depends on them.
The corrections
AGENTS.mdpromised dependencies download automatically on worktree entry, but the hook fires only for Claude'sEnterWorktreeand invoked a barego, which is not onPATHin every shellmise exec --;AGENTS.mdgives the explicitmise trust+mise exec -- go mod downloadcommandsmise run testsruns race detection; thetests:*tasks run CLI, linter-rule and installer tests with no-race.gatewas called a pre-push gate while the PR checklist requiresmise run allgateis named the iteration gatemainunconditionally; self-review T10 said stacked PRs use their real target but offeredgit merge-baseas the fallbackmerge-baseis for ancestry checks after both refs are named, not for choosing a targetCONTRIBUTING.mdandmise.tomlsaid the task tags and pushes;scripts/tag.shcommits and pushes arelease/vX.Y.Zbranch and only prints the tagging commandsAPITokencomment saysAuthMethodselectspatterns.mdcarried a contradiction resolution defending unboundedGetMultiple, butGetMultipleandPullerboth callSetLimitalreadydoc-maintenance.mdrequired every internal package in three places includingCLAUDE.md, while its own rules say keep the entry point short and don't duplicateproject-structure.mdowns the detailed inventory; the entry point keeps routing and the command-group mapdatasources genericandauth login; the registered commands aredatasources queryandloginREADME.mdoffers these skills to Codex, OpenCode and Pi; the workflow required Claude-style task tools with no alternativeVISION.mdlinked a deadARCHITECTURE.mdanchor§ 4 Developer ToolingReviewing order
Seven files are split across the four slices by hunk, so each change sits with the rule it belongs to. In this PR that means
ARCHITECTURE.md(the ADR-006 entry only),DESIGN.md(one stale command path),VISION.md(one anchor),patterns.md(concurrency only), and twointegrate-with-gcxfiles (bootstrap and base selection only). The exit-code and agent-mode hunks in those same files belong to the CLI-contract slice.What this does not change
Runtime behavior, command surfaces, output formats and auth resolution are all untouched. The only Go change is the
APITokendoc comment ininternal/config/types.go. Two generated reference files move with it because they are generated from that struct.Validation
GCX_AGENT_MODE=false mise run allpasses end to end: skill validation, lint (0 issues), Go tests, linter-rule tests, installer tests, build, reference regeneration and docs.mise run referenceleaves no drift.MkDocs reports 33 link warnings, all pre-existing and none naming a file this PR touches. Two of the branch's edits would have added new ones by linking from inside
docs/to root files; both now reference those files the way the surrounding text already does.🤖 Generated with Claude Code