fix(deps): update go-jsonnet to v0.22.0 - #271
Closed
periklis wants to merge 1 commit into
Closed
Conversation
go-jsonnet v0.21.0 does not desugar the index expression of a super[e] access, leaving a nil node that makes the static analyzer panic with "Unexpected node <nil>". Since DidOpen/DidChange call SnippetToAST directly, this takes down the server process, and the client restarts it and re-opens the same document, so any workspace containing such a file is stuck in a crash loop. Fixed upstream in google/go-jsonnet#849, released in v0.22.0. Fixes #270 Signed-off-by: Periklis Tsirakidis <periklis.tsirakidis@grafana.com>
periklis
requested review from
jdbaldry,
julienduchesne and
zzehring
as code owners
July 27, 2026 11:02
Author
|
The failing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #270.
go-jsonnet v0.21.0 does not desugar the index expression of a
super[e]access, leaving a nil node that makes the static analyzer panic withUnexpected node <nil>. BecauseDidOpen/DidChangecallSnippetToASTdirectly, the panic takes down the server process; the client then restarts it and re-opens the same document, so any workspace containing such a file is stuck in a crash loop.Fixed upstream in google/go-jsonnet#849, released in v0.22.0. This is the same bump Renovate proposed in #258, which was autoclosed after a transient
go mod tidyTLS timeout rather than a real incompatibility.Verification
go build ./...succeeds with no source changes;go test ./...passes.initialize+didOpenof a file containingsuper[f.key]: the v0.21.0 build exits 2 with the panic, this build stays alive.Note on the
godirectivego mod tidyraisesgofrom 1.24.0 to 1.24.5 and drops the now-redundanttoolchain go1.24.2line, because go-jsonnet v0.22.0 requires Go 1.24.5. CI resolves its Go version fromgo-version-file: go.mod, so it picks this up automatically.