Plugin E2E: Fix addPanel timeout when dashboardNewLayouts is disabled#2612
Merged
Plugin E2E: Fix addPanel timeout when dashboardNewLayouts is disabled#2612
Conversation
…uts toggle addPanel() unconditionally entered the new Grafana 13 sidebar flow for any Grafana >= 13.0.0, which timed out for 30s when the dashboardNewLayouts toggle was disabled. Detect the toggle and fall back to the legacy toolbar flow when it is off.
sunker
added
patch
Contributor
grafana-plugins-platform-bot
Bot
moved this from 📬 Triage
to 🔬 In review
in Grafana Catalog Team
leventebalogh
approved these changes
May 5, 2026
github-project-automation
Bot
moved this from 🔬 In review
to 🚀 Shipped
in Grafana Catalog Team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
DashboardPage.addPanel()unconditionally entered the new Grafana 13 sidebar flow for any Grafana >= 13.0.0, but the Sidebar container only exists when thedashboardNewLayoutstoggle is on. With the toggle off, everyaddPanel()call timed out for 30s.The fix detects the toggle via
isLegacyFeatureEnabledand falls back to the legacy toolbar flow when it is off (same pattern as thedashboardScenecheck above it).Which issue(s) this PR fixes:
Reported via grafana/grafana#123826.
Special notes for your reviewer:
Regression from #2572 (shipped in 3.5.0). Plugin-e2e CI didn't catch it because
docker-compose.yamlsetsdashboardNewLayouts=true. Verified locally against Grafana 13.0.1 with the toggle off — fails without the fix, passes with it.📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install website@5.5.4-canary.2612.25370213167.0 npm install @grafana/create-plugin@7.3.1-canary.2612.25370213167.0 npm install @grafana/plugin-e2e@3.7.1-canary.2612.25370213167.0 # or yarn add website@5.5.4-canary.2612.25370213167.0 yarn add @grafana/create-plugin@7.3.1-canary.2612.25370213167.0 yarn add @grafana/plugin-e2e@3.7.1-canary.2612.25370213167.0