Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
/packages/create-plugin/ @grafana/grafana-frontend-platform
/packages/eslint-plugin-plugins/ @grafana/plugins-platform-frontend
/packages/plugin-docs-parser/ @grafana/plugins-platform-frontend
/packages/plugin-docs-cli/ @grafana/plugins-platform-frontend
/packages/plugin-e2e/ @grafana/plugins-platform-frontend
/packages/plugin-types-bundler/ @grafana/plugins-platform-frontend
/packages/eslint-plugin-plugins/ @grafana/grafana-catalog
/packages/plugin-docs-parser/ @grafana/grafana-catalog
/packages/plugin-docs-cli/ @grafana/grafana-catalog
/packages/plugin-e2e/ @grafana/grafana-catalog
/packages/plugin-types-bundler/ @grafana/grafana-catalog
Comment on lines +2 to +6
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — verified both. Expanded this PR to also update .github/renovate.json reviewer and packages/plugin-e2e/CONTRIBUTING.md tag instruction. PR description scope still reads "ownership migration" since the additions are within that scope.

Did a parallel sweep across the rest of the migration's repos for similar non-CODEOWNERS references — followed up:

  • grafana/grafana PR #124469: added .github/renovate.json5 reviewer + 13 modowners-style codeowner annotations in go.mod / pkg/build/go.mod
  • grafana/grafana-catalog-team PR README: Update package list #872: updated docs (CLAUDE.md, README.md, two squad docs)
  • grafana/grafana PR #124474 (new, docs-only): breaking-changes-guide.md and scripts/modowners/README.md

GitHub App (grafana-plugins-platform-bot[bot]) and Go module path (github.com/grafana/plugins-platform-provisioned) refs are out of scope — those are separate identities from the team handle.

/packages/react-detect/ @grafana/grafana-frontend-platform
/packages/sign-plugin/ @grafana/plugins-platform-frontend
/packages/sign-plugin/ @grafana/grafana-catalog
/packages/tsconfig/ @grafana/grafana-frontend-platform

/docusaurus/website/ @grafana/grafana-frontend-platform @grafana/docs-plugins
/docusaurus/docs/ @grafana/grafana-frontend-platform @grafana/docs-plugins

/.github/workflows/playwright.yml @grafana/plugins-platform-frontend
/.github/workflows/playwright-nightly.yml @grafana/plugins-platform-frontend
/.github/workflows/playwright.yml @grafana/grafana-catalog
/.github/workflows/playwright-nightly.yml @grafana/grafana-catalog
2 changes: 1 addition & 1 deletion .github/renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
],
"separateMajorMinor": false,
"skipInstalls": false,
"reviewers": ["team:grafana/plugins-platform-frontend"],
"reviewers": ["team:grafana/grafana-catalog"],
"enabledManagers": ["custom.regex", "npm", "github-actions"],
"github-actions": {
"managerFilePatterns": [
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-e2e/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,6 @@ yarn add @grafana/plugin-e2e@0.3.0-canary.623.aedff75.0
yarn e2e:plugin
```

6. If all tests pass in `grafana/grafana` and the PR in `grafana/plugin-tools` is approved, tag `@grafana/plugins-platform-frontend` and ask them to merge the PR.
6. If all tests pass in `grafana/grafana` and the PR in `grafana/plugin-tools` is approved, tag `@grafana/grafana-catalog` and ask them to merge the PR.

7. Once the PR is merged, `auto` will publish a patch/minor release to npm. Then you discard changes from step 5, and can go ahead and install the new release of @grafana/plugin-e2e in grafana/grafana.
Loading