Skip to content

Go SDK: Validate that plugin is not using sdk forks#319

Merged
academo merged 1 commit intomainfrom
academo/validate-forked-sdk
Apr 8, 2025
Merged

Go SDK: Validate that plugin is not using sdk forks#319
academo merged 1 commit intomainfrom
academo/validate-forked-sdk

Conversation

@academo
Copy link
Copy Markdown
Collaborator

@academo academo commented Apr 3, 2025

Fixes #315

@academo academo requested review from a team as code owners April 3, 2025 18:21
@academo academo requested review from andresmgot, jackw, oshirohugo and s4kh and removed request for a team April 3, 2025 18:21
@academo academo self-assigned this Apr 3, 2025
@academo academo added the enhancement New feature or request label Apr 3, 2025
@academo academo moved this from 📬 Triage to 🔬 In review in Grafana Catalog Team Apr 3, 2025
}

func run(pass *analysis.Pass) (interface{}, error) {
if os.Getenv("SKIP_OSV_SCANNER") != "" {
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding this for faster local tests

Comment thread pkg/runner/runner.go
}

func initAnalyzers(analyzers []*analysis.Analyzer, cfg *Config, pluginId string, severityOverwrite analysis.Severity) {
func initAnalyzers(
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting

Comment thread pkg/runner/runner.go

seen[currentAnalyzer] = true

logme.DebugFln("Running analyzer %s", currentAnalyzer.Name)
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding this for local debugging

Copy link
Copy Markdown
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@academo academo merged commit 1e9af50 into main Apr 8, 2025
2 checks passed
@academo academo deleted the academo/validate-forked-sdk branch April 8, 2025 07:20
@github-project-automation github-project-automation Bot moved this from 🔬 In review to 🚀 Shipped in Grafana Catalog Team Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

SDK Validator: Fail go sdk forks

2 participants