Skip to content

Make license validator work with a single license file to prevent library oddities#320

Merged
academo merged 1 commit intomainfrom
academo/refactor-license-validator
May 7, 2025
Merged

Make license validator work with a single license file to prevent library oddities#320
academo merged 1 commit intomainfrom
academo/refactor-license-validator

Conversation

@academo
Copy link
Copy Markdown
Collaborator

@academo academo commented Apr 15, 2025

Modifies the validator so instead of passing the full archive contents to the license library it passes a new temporal directory only with a license file.

This prevents the license library to scan all the files in the archive and potentially detect false positives or get locked on scanning big files

Closes #293

@academo academo requested review from a team as code owners April 15, 2025 14:21
@academo academo requested review from Ukochka and removed request for a team April 15, 2025 14:21
@academo academo requested review from briangann, wbrowne and xnyo and removed request for a team April 15, 2025 14:22
@academo academo self-assigned this Apr 15, 2025
@academo academo moved this from 📬 Triage to 🔬 In review in Grafana Catalog Team Apr 15, 2025
Copy link
Copy Markdown
Member

@xnyo xnyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@academo academo merged commit 97f8d27 into main May 7, 2025
2 checks passed
@academo academo deleted the academo/refactor-license-validator branch May 7, 2025 08:13
@github-project-automation github-project-automation Bot moved this from 🔬 In review to 🚀 Shipped in Grafana Catalog Team May 7, 2025
Ukochka pushed a commit that referenced this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

License validator: simplify logic to not rely on file system scanning

3 participants