Chore: moving all to vault#328
Conversation
tolzhabayev
requested review from
andresmgot,
oshirohugo and
xnyo
and removed request for
a team
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
| run: | | ||
| git config user.name 'grafana-delivery-bot[bot]' | ||
| git config user.email '132647405+grafana-delivery-bot[bot]@users.noreply.github.com' | ||
| git config user.name 'grafana-plugins-platform-bot[bot]' |
There was a problem hiding this comment.
Switched to use the proper username and email
| - name: Generate token | ||
| id: generate_token | ||
| uses: tibdex/github-app-token@3beb63f4bd073e61482598c45c71c1019b59b73a | ||
| uses: actions/create-github-app-token@3ff1caaa28b64c9cc276ce0a02e2ff584f3900c5 # v2.0.2 |
There was a problem hiding this comment.
Moved to the github actions native one
| - uses: actions/setup-node@cdca7365b2dadb8aad0a33bc7601856ffabcc48e # v4.3.0 | ||
| with: | ||
| node-version: "20" | ||
| node-version: "22" |
There was a problem hiding this comment.
Bumped node, because why not
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on refactoring the release workflow by moving secret retrieval to use Vault and updating associated configurations. Key changes include:
- Adding a new step to retrieve secrets via Vault.
- Updating the GitHub App token generation to use different input keys.
- Changing the Node.js version and updating Git configuration details.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/release.yml | Introduces a new Vault secrets retrieval step and updates token generation configuration. |
| .github/workflows/do-release.yml | Updates Git user configuration to use the new bot account for releases. |
github-project-automation
Bot
moved this from 📬 Triage
to 🔬 In review
in Grafana Catalog Team
github-project-automation
Bot
moved this from 🔬 In review
to 🚀 Shipped
in Grafana Catalog Team
No description provided.