chore: exclude synthetic conformance fixtures from secret scanning - #7884
Closed
carles-grafana wants to merge 1 commit into
Closed
carles-grafana wants to merge 1 commit into
carles-grafana wants to merge 1 commit into
Conversation
Add exact-path exclusions for the synthetic legacy corpus and the audit test containing a never-submitted GitLab registration token. These files were still blocked after the catalog exclusion; keep all other conformance files and production code covered.
carles-grafana
requested review from
electron0zero,
ie-pham,
javiermolinar,
mapno,
mattdurham,
mdisibio,
ruslan-mikhailov,
stoewer,
yvrhdn,
zalegrala and
zhxiaogg
as code owners
September 14, 2026 14:48
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The configuration changes are narrowly scoped and have no unresolved review issues.
Pull request overview
Adds narrowly scoped secret-scanning exclusions for synthetic conformance fixtures while keeping production paths covered.
Changes:
- Excludes the synthetic legacy corpus.
- Excludes the synthetic audit test.
- Retains scanning for other paths.
File summaries
| File | Summary |
|---|---|
.github/secret_scanning.yml |
Adds two exact-path fixture exclusions. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
The secret-detection feature is being amended to remove tools/secrets-conformance and tools/secrets-benchmark. These two conformance fixture files will no longer be included, so their additional secret-scanning exclusions are no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Follow up on #7881 with two exact-path exclusions for fixtures in the pending secret-detection feature:
tools/secrets-conformance/testdata/legacy.json: a corpus explicitly markedscope: synthetic, containing provider-format test values and public examples.tools/secrets-conformance/synthetic_audit_test.go: includes the synthetic manually assigned GitLab registration token inTestManuallyAssignedGitLabRegistrationToken; the test documents that the value is never submitted.GitHub push protection still blocks the feature commit on these two files after the catalog exclusion. The displayed findings identify Slack, webhook, Stripe, and GitLab fixture values. This change excludes only those two files, not the conformance directory or all Go tests. Production code remains covered.
Verification and limitations
As with #7881, merge this configuration into the default branch first. Forks receiving the feature push must also sync the configuration to their own default branch.