Skip to content

Test for url_deny_list - #7891

Merged
ruslan-mikhailov merged 1 commit into
grafana:mainfrom
ruslan-mikhailov:tests/url_deny_list
Sep 15, 2026
Merged

ruslan-mikhailov merged 1 commit into
grafana:mainfrom
ruslan-mikhailov:tests/url_deny_list

Conversation

@ruslan-mikhailov

Copy link
Copy Markdown
Contributor

What this PR does: it adds a test for url_deny_list. It can be used for verifying rules.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • Changelog entry added under .chloggen/ (run make chlog-new, or make chlog-new FILENAME=<name> to override the default branch-name file; see .chloggen/README.md)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Only a minor changelog-label nit remains; no blocking issues were identified.

Pull request overview

Adds regression tests for URL deny-list matching and backend forwarding.

Changes:

  • Covers multiple query-string encodings.
  • Tests denied and allowed TraceQL expressions.
  • Verifies denied requests do not reach the backend.
File summaries
File Summary
modules/frontend/pipeline/async_deny_list_middleware_test.go Adds encoded query deny-list coverage.
Review details

Suppressed comments (1)

modules/frontend/pipeline/async_deny_list_middleware_test.go:39

  • MEDIUM: Could you add the Skip Changelog label (or use a chore: title) for this test-only PR? The changelog workflow runs for the current title and fails when no .chloggen/*.yaml entry is added, even though this change has no user-facing behavior to document.
func TestURLDenyListMiddlewareEncodedQueries(t *testing.T) {
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@javiermolinar

Copy link
Copy Markdown
Contributor

cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 498aa1f. Configure here.

@ruslan-mikhailov
ruslan-mikhailov merged commit 2c6dcdd into grafana:main Sep 15, 2026
36 checks passed
@ruslan-mikhailov
ruslan-mikhailov deleted the tests/url_deny_list branch September 15, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants