Test for url_deny_list - #7891
Merged
ruslan-mikhailov merged 1 commit intoSep 15, 2026
Merged
Conversation
ruslan-mikhailov
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
mapno,
mattdurham,
mdisibio,
stoewer,
yvrhdn,
zalegrala and
zhxiaogg
as code owners
September 15, 2026 07:09
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Only a minor changelog-label nit remains; no blocking issues were identified.
Pull request overview
Adds regression tests for URL deny-list matching and backend forwarding.
Changes:
- Covers multiple query-string encodings.
- Tests denied and allowed TraceQL expressions.
- Verifies denied requests do not reach the backend.
File summaries
| File | Summary |
|---|---|
modules/frontend/pipeline/async_deny_list_middleware_test.go |
Adds encoded query deny-list coverage. |
Review details
Suppressed comments (1)
modules/frontend/pipeline/async_deny_list_middleware_test.go:39
- MEDIUM: Could you add the
Skip Changeloglabel (or use achore:title) for this test-only PR? The changelog workflow runs for the current title and fails when no.chloggen/*.yamlentry is added, even though this change has no user-facing behavior to document.
func TestURLDenyListMiddlewareEncodedQueries(t *testing.T) {
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 498aa1f. Configure here.
mapno
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does: it adds a test for
url_deny_list. It can be used for verifying rules.Which issue(s) this PR fixes:
Fixes #
Checklist
.chloggen/(runmake chlog-new, ormake chlog-new FILENAME=<name>to override the default branch-name file; see.chloggen/README.md)