Skip to content

don't use vars, use our #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haarg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

don't use vars, use our #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions lib/XML/SAX.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,13 @@
package XML::SAX;

use strict;
use vars qw($VERSION @ISA @EXPORT_OK);

$VERSION = '1.02';
our $VERSION = '1.02';

use Exporter ();
@ISA = ('Exporter');
our @ISA = ('Exporter');

@EXPORT_OK = qw(Namespaces Validation);
our @EXPORT_OK = qw(Namespaces Validation);

use File::Basename qw(dirname);
use File::Spec ();
Expand Down
3 changes: 1 addition & 2 deletions lib/XML/SAX/ParserFactory.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@
package XML::SAX::ParserFactory;

use strict;
use vars qw($VERSION);

$VERSION = '1.02';
our $VERSION = '1.02';

use Symbol qw(gensym);
use XML::SAX;
Expand Down
6 changes: 2 additions & 4 deletions lib/XML/SAX/PurePerl.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@
package XML::SAX::PurePerl;

use strict;
use vars qw/$VERSION/;

$VERSION = '1.02';
our $VERSION = '1.02';

use XML::SAX::PurePerl::Productions qw($NameChar $SingleChar);
use XML::SAX::PurePerl::Reader;
Expand All @@ -27,8 +26,7 @@ else {
require XML::SAX::PurePerl::UnicodeExt;
}

use vars qw(@ISA);
@ISA = ('XML::SAX::Base');
our @ISA = ('XML::SAX::Base');

my %int_ents = (
amp => '&',
Expand Down
4 changes: 1 addition & 3 deletions lib/XML/SAX/PurePerl/Exception.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@ use strict;

use overload '""' => "stringify";

use vars qw/$StackTrace/;

$StackTrace = $ENV{XML_DEBUG} || 0;
our $StackTrace = $ENV{XML_DEBUG} || 0;

sub throw {
my $class = shift;
Expand Down
5 changes: 2 additions & 3 deletions lib/XML/SAX/PurePerl/Reader.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@ use strict;
use XML::SAX::PurePerl::Reader::URI;
use Exporter ();

use vars qw(@ISA @EXPORT_OK);
@ISA = qw(Exporter);
@EXPORT_OK = qw(
our @ISA = qw(Exporter);
our @EXPORT_OK = qw(
EOF
BUFFER
LINE
Expand Down
3 changes: 1 addition & 2 deletions lib/XML/SAX/PurePerl/Reader/Stream.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
package XML::SAX::PurePerl::Reader::Stream;

use strict;
use vars qw(@ISA);

use XML::SAX::PurePerl::Reader qw(
EOF
Expand All @@ -15,7 +14,7 @@ use XML::SAX::PurePerl::Reader qw(
);
use XML::SAX::Exception;

@ISA = ('XML::SAX::PurePerl::Reader');
our @ISA = ('XML::SAX::PurePerl::Reader');

# subclassed by adding 1 to last element
use constant FH => 8;
Expand Down
3 changes: 1 addition & 2 deletions lib/XML/SAX/PurePerl/Reader/String.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
package XML::SAX::PurePerl::Reader::String;

use strict;
use vars qw(@ISA);

use XML::SAX::PurePerl::Reader qw(
LINE
Expand All @@ -13,7 +12,7 @@ use XML::SAX::PurePerl::Reader qw(
EOF
);

@ISA = ('XML::SAX::PurePerl::Reader');
our @ISA = ('XML::SAX::PurePerl::Reader');

use constant DISCARDED => 8;
use constant STRING => 9;
Expand Down
9 changes: 4 additions & 5 deletions t/21saxini.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ use warnings;
use File::Path;
use Fatal qw(open close chdir mkpath);
use XML::SAX;
use vars qw(*FILE);

is(scalar(@{XML::SAX->parsers}), 0, 'no known parsers');
ok(XML::SAX->add_parser(q(XML::SAX::PurePerl)), 'added PurePerl');
Expand Down Expand Up @@ -61,8 +60,8 @@ done_testing();

sub write_file {
my ($file, $data) = @_;
open(FILE, ">$file");
print FILE $data;
print FILE "\n";
close FILE;
open(my $FILE, ">", $file);
print $FILE $data;
print $FILE "\n";
close $FILE;
}