build(ts): add Phase 1 TypeScript build pipeline - #55
Conversation
Introduce the compiled-package pipeline without converting runtime modules: - tsconfig.json emits ESM to dist/ (allowJs on, checkJs off) - package.json ships dist/ and adds build + pretest scripts - bin/lazyglm.js imports dist/cli.js (compiled) instead of src/cli.js - README + docs/typescript-migration.md document the build step pretest lifecycle runs build before npm test, so dist/ exists for the CLI smoke and npm pack steps in CI without an explicit build step. Scope: build pipeline only. No .js->.ts conversion, no bundler, no version/publish flow change, no runtime behavior change. Refs #28
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9bb6cab986
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Status: draft verified clean on latest head; marked ready for review. Evidence:
Next: awaiting independent Codex review for current head (trigger already pending from graphanov) |
…re pack/install Resolves Codex P2 review thread on package.json:15. dist/ is gitignored build output but bin/lazyglm.js imports dist/cli.js, so a fresh npm pack or npm install without a prior npm test produced a broken tarball missing dist/. prepack (npm pack) and prepare (npm install) now run npm run build deterministically, same as the existing pretest hook. Scope: package.json scripts only. No version/publish/runtime change. Refs #28
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Scope
Out of scope
Verification
Risk
Linked issue
Refs #28
Notes
.github/workflows/ci.yml(adding an explicitnpm run buildstep before typecheck) is prepared locally but could not be pushed in this PR: the configured deployment token lacks theworkflowscope, so GitHub rejects pushes that touch workflow files. Thepretestlifecycle covers CI correctness in the meantime (it buildsdist/beforenpm test, so the smoke andnpm pack --dry-runsteps see the compiled output). The ci.yml update is a recommended follow-up for clarity; it requires either a token withworkflowscope or an owner push.Authority boundary
john-lomein did not merge, publish, release, dispatch workflows, change settings, force-push, rewrite history, or touch secrets.