feat(ts): convert hooks, MCP, and plugins to TypeScript (Phase 4) - #60
Merged
Merged
Conversation
Convert 15 modules from .js to .ts following the Phase 3 pattern: - src/hooks/engine.js, src/hooks/schema.js - src/mcp/config.js - src/plugins/* (11 modules) - src/skills/index.js All new .ts files use types from src/types/index.ts (no any types). Tests import from dist/ (pretest builds before test runs). Verification: - npm run typecheck: pass (strict: true) - npm run build: pass - npm run test: 445/445 pass - node bin/lazyglm.js --version: pass - npm pack --dry-run: correct contents Closes #52
Owner
Author
|
@codex review |
Owner
Author
|
Status: draft PR verified; marking ready for review. Evidence:
Next: independent review on this head (codex trigger already pending from owner) |
graphanov
marked this pull request as ready for review
June 29, 2026 13:15
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
Out of scope
Verification
Risk
Linked issue
Closes #52
Authority boundary
john-lomein did not merge, publish, release, dispatch workflows, change settings, force-push, rewrite history, or touch secrets.