This repository was archived by the owner on Feb 22, 2024. It is now read-only.
fix: ensure GraphTokenLockWallet implementations are initialized#88
Open
pcarranzav wants to merge 1 commit intomainfrom
Open
fix: ensure GraphTokenLockWallet implementations are initialized#88pcarranzav wants to merge 1 commit intomainfrom
pcarranzav wants to merge 1 commit intomainfrom
Conversation
pcarranzav
force-pushed
the
pcv/impl-initialize
branch
from
66c6998 to
0c6dcc3
Compare
pcarranzav
changed the title
Maikol
approved these changes
Sep 3, 2023
tmigone
approved these changes
Sep 8, 2023
Member
tmigone
left a comment
tmigone
left a comment
There was a problem hiding this comment.
Might be trivial, but could add a simple test 🦺
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There should be no risk in implementations not being initialized as they don't do any delegatecalls, but it's cleaner to keep them initialized.
Tested by deploying an L2GraphTokenLockWallet to arbitrum-goerli: https://goerli.arbiscan.io/address/0x666C40Bd82a1dA5CfF9B7fe731246c128BdAFe62#code