modify making token by byte position, not rune position at readName#605
Open
nktks wants to merge 1 commit intographql-go:masterfrom
Open
modify making token by byte position, not rune position at readName#605nktks wants to merge 1 commit intographql-go:masterfrom
nktks wants to merge 1 commit intographql-go:masterfrom
Conversation
nktks
changed the title
nktks
force-pushed
the
fix/multi-byte-parse
branch
from
4ae0b09 to
ea0716e
Compare
|
Confirming that this bug still exists on |
This was referenced Jan 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I tried to parse SDL with multibyte comment , and failed.
I think, the cause is that the start and end positions of the token created in
readNamewere created as the rune position.If the comment contains a multibyte character string, the start and end of the token shifts from the actual byte position, and it seems that the token is not parsed correctly.
Please review this.
Thanks!