Skip to content
This repository was archived by the owner on Mar 1, 2021. It is now read-only.

Create record expense script#33

Open
kaguillera wants to merge 7 commits into
masterfrom
record-expense
Open

Create record expense script#33
kaguillera wants to merge 7 commits into
masterfrom
record-expense

Conversation

@kaguillera

Copy link
Copy Markdown
Contributor

This is the stub for the record expense script that I intend to write

@kaguillera

Copy link
Copy Markdown
Contributor Author

So I started working on this. And I have a few issues to work on. The most immediate is the account names for expenses such as Github, Heroko, Travis etc.

@kaguillera

Copy link
Copy Markdown
Contributor Author

IRL we came to the agreement to use
Expense:Operations:SAS for those operation expenses.
Software-As a-Service (SAS) expenses

@chadwhitacre

Copy link
Copy Markdown
Contributor

It'd be SaaS. We could also just use Software.

@kaguillera

Copy link
Copy Markdown
Contributor Author

I was wondering about that ☹️

@kaguillera

kaguillera commented Dec 2, 2016

Copy link
Copy Markdown
Contributor Author

Thinking this through. The previous commit has absolutely no validation. So here are the intended steps (Disclaimer: These steps may change with out notice 😀 )

  • Validate the amount as a float and not rubbish
  • Validate the date (i.e. It is in the correct format, it is an actual date and not in the future, etc.)
  • Allow for different types of expenses (e.g. Lodging, Parking, Printing). Thus I need to verify that the account is a valid and active account.
  • (Optional) Add an option for input of a comment for expense.
    Oh and should I create the .dat file if it does not exist?

@kaguillera

Copy link
Copy Markdown
Contributor Author

So I am thinking I should have tests but just can't think of what to test. Any suggestion is welcome.

@kaguillera

Copy link
Copy Markdown
Contributor Author

Would we ever want to account for things in the future and should we allow it. For now I will not bother to check for that since @whit537 suggested tht I write the script as though I am the user. I can't shake the practice for trying to make code idiot proof

@chadwhitacre

Copy link
Copy Markdown
Contributor

I suggest we allow any date, but make it optional with a default of "today".

@kaguillera

Copy link
Copy Markdown
Contributor Author

That is what I did cool

@kaguillera

kaguillera commented Dec 2, 2016

Copy link
Copy Markdown
Contributor Author

A few things...
Planning add the option to put a comment when entering expense.
I will have to figure out why Travis is sticking and not completing.

@chadwhitacre

Copy link
Copy Markdown
Contributor

I think I saw a notice that their macOS infrastructure is lagging.

@kaguillera

Copy link
Copy Markdown
Contributor Author

So @whit537 Now that we have started porting to beancount I guess this PR is not longer necessary the question is should I just change the script in this PR to create a beancount file instead.
Or should closed this PR and make a new one to do that?

@chadwhitacre

Copy link
Copy Markdown
Contributor

@kaguillera I think it depends on how useful Fava is for editing Beancount files. If Fava is advanced enough then we may not need our own script after all. Have you tried out Fava yet?

@kaguillera

Copy link
Copy Markdown
Contributor Author

I have only got it up and running on my system but I have not tried to do anything advanced with it.

@chadwhitacre

Copy link
Copy Markdown
Contributor

Can you explore the editing features in Fava and see if that is sufficient for our needs?

@kaguillera

Copy link
Copy Markdown
Contributor Author

Wil do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants