condition to catch and repair parsing of books with a single chapter - #2
Open
JMNofziger wants to merge 1 commit into
Open
condition to catch and repair parsing of books with a single chapter#2JMNofziger wants to merge 1 commit into
JMNofziger wants to merge 1 commit into
Conversation
Author
|
excerpt from git-status-output.txt to preview the untracked files being created - this demonstrates the creation of the previously missing chapter output for single chapter books: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue is described here: #1
Book objects with a single chapter did not contain the chapter within an array and would have an undefined length - checking for this condition allowed me to perform the necessary modification on only the affected books. The book object for Genesis is cloned to serve as a correctly parsed template and the clone then has its properties updated to hold the values of the affected book. The task then continues normally.
Tested locally. Manually checked a few books to confirm expected output to gh-pages, and confirmed that git status showed only the expected new directories/files were being created. I've included a file git-status-output.txt with the output from git after
grunt convert --htmlwas run with the new code changes.I'm sure there's a resolution to be found at the point of parsing but I wanted to quickly submit a PR to simply get the missing chapters up on the gratis.bible webpages.