Conversation
|
Preview is ready. |
SimbiozizV
force-pushed
the
layered_plugin
branch
from
a7d30ef to
2a41767
Compare
| * Multipoint connection that draws segments as Bezier curves (horizontal segments as lines). | ||
| * From commit a90f9c65 (ytsaurus-ui) — alternative line representation for layout graphs. | ||
| */ | ||
| export class BezierMultipointConnection extends MultipointConnection { |
There was a problem hiding this comment.
is this implementation of BezierConnection supports of setting bezierConnectionDirection ?
Line 50 in 465c97b
| @@ -1,4 +1,6 @@ | |||
| export * from "./BaseConnection"; | |||
| export * from "./BlockConnection"; | |||
| export * from "./MultipointConnection"; | |||
There was a problem hiding this comment.
Thank you for moving these components to components/canvas, this is really the right place for them. But keep in mind that MuptipointConnection used to be exported from the entrypoint @gravity-ui/graph/react.
import { MultipointConnection } from "@gravity-ui/graph/react";So, for backward compatibility, I suggest duplicating this export to src/react-components/elk/index.ts
import { MultipointConnection as M } from "../../components/canvas/connections/MultipointConnection";
/**
* @deprecated use `import { MultipointConnection } from "@gravity-ui/graph"`
*/
export const MultipointConnection = M;| text?: string; | ||
| }; | ||
|
|
||
| export type TMultipointConnection = TConnection & { |
There was a problem hiding this comment.
I think it's better to move this type closer to the MultipointConnection component.
| onError?: (e: Error) => void; | ||
| }; | ||
|
|
||
| export function useLayeredLayout(params: UseLayeredLayoutParams) { |
There was a problem hiding this comment.
Could you add some unit tests for that hook?
| useEffect(() => { | ||
| let isCancelled = false; | ||
|
|
||
| runLayout() |
There was a problem hiding this comment.
Please add setIsLoading(true).
3 participants
No description provided.