feat(#268): New Kit: Cisco ASA & Cisco FTD - Initial Release#269
Open
kyle-mallett-gravwell wants to merge 9 commits into
Open
feat(#268): New Kit: Cisco ASA & Cisco FTD - Initial Release#269kyle-mallett-gravwell wants to merge 9 commits into
kyle-mallett-gravwell wants to merge 9 commits into
Conversation
# Cisco ASA & Cisco FTD Kit(s) ## What is the feature to be added? - Make a kit for Cisco ASA - Make a kit for Cisco FTD ## Why should we add this feature? (Business justification? What problem is the feature trying to solve?) Useful for customers utilizing that product. ## How does this feature address the above problem? Makes getting up and running faster for Cisco ASA/FTD logs ## Any other comments? gravwell#268 <!-- The title of this PR should have the form: [TYPE]([ISSUE_NUMBER]): [CHANGELOG_MESSAGE] - If [TYPE] is fix or feat, the CHANGELOG_MESSAGE will be included in customer-facing, release change logs. - Other [TYPE]s WILL NOT be included in release change logs. - Check out https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#type for other type ideas, or invent your own. --> This PR addresses [[ISSUE_LINK](gravwell#268)] ## This PR proposes... - ## PR Tasks <!-- Add tasks to this list as needed --> - [ ] e2e and/or unit tests included. If not, please provide an explanation. - [ ] **Bug fixes only:** minimal repro steps included on the issue (for PR QA + Release QA). ## Reviewer Tasks <!-- Add tasks to this list as needed --> - [ ] e2e or unit tests are present to test the proposed changes. - [ ] Code is sufficiently documented. - [ ] Code meets quality and correctness expectations. <!-- The title of this PR should have the form: [TYPE]([ISSUE_NUMBER]): [CHANGELOG_MESSAGE] - If [TYPE] is fix or feat, the CHANGELOG_MESSAGE will be included in customer-facing, release change logs. - Other [TYPE]s WILL NOT be included in release change logs. - Check out https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#type for other type ideas, or invent your own. --> This PR addresses [ISSUE_LINK] ## This PR proposes... - ## PR Tasks <!-- Add tasks to this list as needed --> - [ ] e2e and/or unit tests included. If not, please provide an explanation. - [ ] **Bug fixes only:** minimal repro steps included on the issue (for PR QA + Release QA). ## Reviewer Tasks <!-- Add tasks to this list as needed --> - [ ] e2e or unit tests are present to test the proposed changes. - [ ] Code is sufficiently documented. - [ ] Code meets quality and correctness expectations.
kyle-mallett-gravwell
requested review from
Lawrence-Wellman-Gravwell,
bronson-peto-gravwell,
keith-smiley-gravwell and
mike-wade-gravwell
and removed request for
Lawrence-Wellman-Gravwell,
bronson-peto-gravwell and
keith-smiley-gravwell
Contributor
Author
|
@mike-wade-gravwell when you get the chance |
Contributor
|
assigning bronson for review |
Collaborator
|
Holding off on approving these while we check into any broader changes we may look to make with kits in Q2 release. Would like to include any additional adjustments if we already are going to be updating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cisco ASA & Cisco FTD Kit(s)
What is the feature to be added?
Why should we add this feature? (Business justification? What problem is the feature trying to solve?)
Useful for customers utilizing that product.
How does this feature address the above problem?
Makes getting up and running faster for Cisco ASA/FTD logs
Any other comments?
#268
This PR addresses [ISSUE_LINK]
This PR proposes...
PR Tasks
Reviewer Tasks
This PR addresses [ISSUE_LINK]
This PR proposes...
PR Tasks
Reviewer Tasks
This PR addresses [ISSUE_LINK]
This PR proposes...
PR Tasks
Reviewer Tasks