Skip to content

chore: Node24 update#11

Merged
ashnwade merged 5 commits into
gravwell:mainfrom
michael-wisely-gravwell:node24-update
Apr 7, 2026
Merged

chore: Node24 update#11
ashnwade merged 5 commits into
gravwell:mainfrom
michael-wisely-gravwell:node24-update

Conversation

@michael-wisely-gravwell
Copy link
Copy Markdown
Contributor

This PR addresses https://github.com/gravwell/issues/issues/2251

This PR proposes...

  • adding a shell.nix that uses Node 24
  • bumping @types/node to Node 24
  • bumping typescript so that it can compile the types in @types/node
  • bumping eslint & co so that they can lint the bumped version of typescript
  • rebuilding the project
    • This is really what it was all leading to. Ensuring the compiled code will be happy running on Node 24.

PR Tasks

  • e2e and/or unit tests included. If not, please provide an explanation.
    • This repo could perhaps use tests, but that's outside the scope of the dep upgrade and rebuild here.

Reviewer Tasks

  • e2e or unit tests are present to test the proposed changes.
  • Code is sufficiently documented.
  • Code meets quality and correctness expectations.

Copy link
Copy Markdown
Contributor

@ashnwade ashnwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashnwade ashnwade merged commit 999c563 into gravwell:main Apr 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants