Conversation
…nning the ping test Signed-off-by: sivakondri-CT <kondru.sankar@candelatech.com>
smileyrekiere
left a comment
smileyrekiere
left a comment
There was a problem hiding this comment.
May there be an example using the upstream port (See that the example goes to google.com, )
VERIFIED CLI : python3 lf_interop_ping_plotter.py --mgr 192.168.207.78 --target 1.1.eth1 --real --ping_interval 5 --ping_duration 60s --use_default_config |
sivakondri-CT
force-pushed
the
ping_iot
branch
from
de46c6d to
422c546
Compare
… ping report
VERIFIED CLI 1 : python3 lf_interop_ping_plotter.py --mgr 192.168.207.78 \
--target www.google.com \
--real --ping_interval 5 \
--ping_duration 60s \
--use_default_config \
--iot_test \
--iot_testname "Pingiot"
VERIFIED CLI 2 : python3 lf_interop_ping_plotter.py --mgr 192.168.207.78 \
--target www.google.com \
--real --ping_interval 5 \
--ping_duration 60s \
--use_default_config
Signed-off-by: sivakondri-CT <kondru.sankar@candelatech.com>
sivakondri-CT
force-pushed
the
ping_iot
branch
from
422c546 to
b9538d1
Compare
memnochproxy
left a comment
memnochproxy
left a comment
There was a problem hiding this comment.
Please do not copy-paste whole methods all over the codebase. That make maintenance take a lot longer, and does not follow the DNRY rule. https://en.wikipedia.org/wiki/Don%27t_repeat_yourself
LFCliBase::parse_time
| exit(1) | ||
|
|
||
|
|
||
| def duration_to_seconds(duration: str) -> int: |
There was a problem hiding this comment.
Replace calls to this with LFCliBase::parse_time
| thread = threading.Thread(target=trigger_iot, args=(iot_ip, iot_port, iot_iterations, iot_delay, iot_device_list, iot_testname, iot_increment)) | ||
| thread.start() | ||
| else: | ||
| total_secs = duration_to_seconds(args.ping_duration) |
There was a problem hiding this comment.
LFCliBase::parse_time
Hi @memnochproxy,Thanks for the reminder.For the next changes I’ll make sure to move common methods into a shared class and reuse them to avoid duplicated logic and I’ve updated the PR to use LFCliBase::parse_time |
3 participants
No description provided.