Skip to content

Integrate Iot in Mixed Traffic#198

Merged
memnochproxy merged 2 commits intogreearb:masterfrom
goyalsaurabh06:mixed_traffic_iot
Dec 15, 2025
Merged

Integrate Iot in Mixed Traffic#198
memnochproxy merged 2 commits intogreearb:masterfrom
goyalsaurabh06:mixed_traffic_iot

Conversation

@sivakondri-CT
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Collaborator

@smileyrekiere smileyrekiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sivakondri-CT see that threading is used, threads will share resources is that the intent? Is the intent to communicate between threads?

@sivakondri-CT
Copy link
Copy Markdown
Contributor Author

@sivakondri-CT see that threading is used, threads will share resources is that the intent? Is the intent to communicate between threads?
Hi @smileyrekiere, The main intention is to trigger the IoT test while the Mixed Traffic test is running, so we can observe how performance varies in the presence of active IoT devices. This logic needs to run in a separate thread because both the Mixed Traffic test and the IoT test must execute in parallel. A similar approach will be used when integrating IoT tests with other test cases as well.

…ixed traffic test

Signed-off-by: sivakondri-CT <kondru.sankar@candelatech.com>
Copy link
Copy Markdown
Collaborator

@memnochproxy memnochproxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove duration_to_seconds, replace with LFCliBase::parse_time

logger.info('Iot Test Completed.')


def duration_to_seconds(duration):
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace calls to this method with LFCliBase parse_time

else:
selected_tests = [int(t) for t in args.tests]
duration_map = {
1: duration_to_seconds(getattr(args, "ping_test_duration", 0)),
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use LFCliBase::parse_time please

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @memnochproxy, I have updated the PR to use LFCliBase::parse_time

…ed traffic test report

VERIFIED CLI 1 : python3 lf_mixed_traffic.py --mgr 192.168.207.78 \
                                             --upstream_port eth1 \
                                             --test_name mixedtraffic \
                                             --mixed_traffic_loop 1 \
                                             --real \
                                             --use_default_config \
                                             --pre_cleanup \
                                             --target www.google.com \
                                             --ping_interval 5 \
                                             --ping_test_duration 1m \
                                             --side_a_min 0 \
                                             --side_b_min 10000000 \
                                             --traffic_type lf_tcp \
                                             --tos VO,VI,BE,BK \
                                             --qos_test_duration 1m \
                                             --tests 1 2 \
                                             --iot_test \
                                             --iot_delay 5 \
                                             --iot_device_list "switch.smart_plug_1_socket_1" \
                                             --iot_testname "mixedtraffic_iot"
VERIFIED CLI 2 : python3 lf_mixed_traffic.py --mgr 192.168.207.78 \
                                             --upstream_port eth1 \
                                             --test_name mixedtraffic \
                                             --mixed_traffic_loop 1 \
                                             --real \
                                             --use_default_config \
                                             --pre_cleanup \
                                             --target www.google.com \
                                             --ping_interval 5 \
                                             --ping_test_duration 1m \
                                             --side_a_min 0 \
                                             --side_b_min 10000000 \
                                             --traffic_type lf_tcp \
                                             --tos VO,VI,BE,BK \
                                             --qos_test_duration 1m \
                                             --tests 1 2
Signed-off-by: sivakondri-CT <kondru.sankar@candelatech.com>
Copy link
Copy Markdown
Collaborator

@memnochproxy memnochproxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@memnochproxy memnochproxy merged commit f6932e1 into greearb:master Dec 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants