Skip to content

Update SaveDialog to add missing type information#5300

Merged
greenbonebot merged 1 commit into
mainfrom
update-save-dialog-types
May 19, 2026
Merged

Update SaveDialog to add missing type information#5300
greenbonebot merged 1 commit into
mainfrom
update-save-dialog-types

Conversation

@bjoernricks
Copy link
Copy Markdown
Contributor

What

Update SaveDialog to add missing type information

Why

Add missing type information for the setError and handleSaveClick functions. With types it is easier to know what's expected.

Add missing type information for the setError and handleSaveClick
functions. With types it is easier to know what's expected.
@bjoernricks bjoernricks requested a review from a team as a code owner May 19, 2026 13:43
@greenbonebot greenbonebot enabled auto-merge (rebase) May 19, 2026 13:43
@github-actions
Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 061a3b2.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@greenbonebot greenbonebot merged commit 9d8e8df into main May 19, 2026
25 checks passed
@greenbonebot greenbonebot deleted the update-save-dialog-types branch May 19, 2026 13:54
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.99%. Comparing base (7eefb47) to head (061a3b2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5300   +/-   ##
=======================================
  Coverage   78.99%   78.99%           
=======================================
  Files        1216     1216           
  Lines       32074    32074           
  Branches     9543     9543           
=======================================
  Hits        25337    25337           
  Misses       6030     6030           
  Partials      707      707           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants