Skip to content

Fix displaying errors if creating a credential in alert dialog fails #5301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greenbonebot merged 1 commit into from
May 19, 2026
+1 −7
Merged

Fix displaying errors if creating a credential in alert dialog fails #5301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/web/pages/alerts/AlertComponent.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ const AlertComponent = ({
useState(false);
const [credentialDialogTitle, setCredentialDialogTitle] = useState('');
const [credentialTypes, setCredentialTypes] = useState([]);
const [credentialError, setCredentialError] = useState();

const [id, setId] = useState(undefined);
const [alert, setAlert] = useState(undefined);
Expand Down Expand Up @@ -285,7 +284,7 @@ const AlertComponent = ({

const handleCreateCredential = credentialData => {
let credentialId;
gmp.credential
return gmp.credential
.create(credentialData)
.then(response => {
credentialId = response.data.id;
Expand All @@ -310,9 +309,6 @@ const AlertComponent = ({
} else if (String(credentialTypeRef.current) === 'pw') {
setMethodDataPkcs12Credential(credentialId);
}
})
.catch(error => {
setCredentialError(error.message);
});
};

Expand Down Expand Up @@ -1175,11 +1171,9 @@ const AlertComponent = ({
)}
{credentialDialogVisible && (
<CredentialDialog
error={credentialError}
title={credentialDialogTitle}
types={credentialTypes}
onClose={handleCloseCredentialDialog}
onErrorClose={() => setCredentialError(undefined)}
onSave={handleCreateCredential}
/>
)}
Expand Down
Loading