Migrated to Python3#26
Open
tyagi-iiitv wants to merge 10 commits into
Open
Conversation
gwaybio
approved these changes
Apr 21, 2020
Collaborator
gwaybio
left a comment
gwaybio
left a comment
There was a problem hiding this comment.
looks great @tyagi-iiitv!! Thanks for your interest in the project! Happy to continue reviewing future PRs if indeed you are interested. I am VERY interested in pushing this topic further and have thought quite extensively about project strategy 😄
| from model_objects import model_parameters | ||
| from DataSetInfoAbstractClass import dataSetInfoAbstract | ||
| import cPickle | ||
| import pickle |
Collaborator
There was a problem hiding this comment.
can remove this - doesn't look like it needs to be imported twice! (see line 17)
| from model_objects import model_parameters | ||
| from DataSetInfoAbstractClass import dataSetInfoAbstract | ||
| import cPickle | ||
| import pickle |
Comment on lines
+63
to
+66
| # with open(self.training_file, "rb") as fp: | ||
| # (x_train, a_train) = cPickle.load(fp) | ||
| # with open(self.testing_file, "rb") as fp: | ||
| # (x_test, a_test) = cPickle.load(fp) |
Collaborator
There was a problem hiding this comment.
you can go ahead and delete this
Comment on lines
+41
to
+44
| # if not os.path.exists(os.path.join('Data', 'Training', | ||
| # '{}_Training.pkl'.format(dataSetInfo. | ||
| # name))): | ||
| # unpackFiles(dataSetInfo.name) |
Collaborator
|
bump @tyagi-iiitv - wondering if you've given this any more thought. Feel free to ignore! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I migrated this project to Python3 and added a sample MNIST dataset file