Repository navigation
Conversation
The installed gain-map and compressed-ICC headers declare five helpers whose implementations live in extras, leaving normal libjxl consumers with undefined symbols. Move the existing implementations into libjxl and separate readers from writers so jxl_dec does not acquire encoder dependencies. Update the CMake, Bazel, and GN source lists without changing public signatures or codec behavior. Add an installed C consumer that links using only libjxl pkg-config metadata and checks bundle/ICC serialization, plus a decoder-only CTest consumer that reads fixed synthetic bytes without encoder linkage. Refresh the Linux loader cache before the existing installed-examples CI step. Fixes libjxl#4865. Validation: the installed consumer fails with all five symbols missing on unmodified upstream on macOS and Linux; the decoder-only consumer fails with both reader symbols missing. Patched shared/static consumers pass on macOS, Linux, and Windows. The decoder regression passes CTest in macOS shared, static-libjxl, and lean builds and runs directly on Linux. Existing focused bundle/ICC tests and formatting/source-list checks pass. The identical library/test changes passed 114 checks in #1, including Bazel, WASM, Windows, macOS, Linux, cross-testing, and conformance. That validation branch also contains unrelated mingw32 and Intel SDE CI repairs excluded here. Windows pkg-config and GN builds were not tested; local static lcms testing on macOS needed an explicit lcms dependency due to existing package metadata.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-only CI validation of the exact upstream submission commit
0554c38b2783e43a3f3239b4977af89fde7621e1, against upstream main ate394120180f7bae73506c9c4435ed95092709a19. This PR is for validation, not for merging into the fork base branch. No upstream PR has been submitted.The head contains one commit with the issue link, rationale, and testing details required by CONTRIBUTING.md. It excludes the independent mingw32 and Intel SDE workflow repairs present in fork PR #1, so this run may reproduce those existing setup failures. Results for this exact head are pending.
The installed gain-map and compressed-ICC headers declare functions that applications cannot link through libjxl because their implementations live in extras.
Move the five existing helpers into libjxl without changing their signatures or behavior. Split the read and write implementations so decoder-only builds do not pull in encoder code, and update the CMake, Bazel, and GN source lists.
Two regression checks cover public linkage: a C example uses only the installed libjxl pkg-config package and checks bundle/ICC roundtrips; a CTest consumer links only to jxl_dec and reads fixed synthetic bytes without calling encoder helpers. The example runs in the existing installed-examples CI step, with a Linux loader-cache refresh after installation.
Related upstream issue: libjxl#4865.
Testing
The synthetic payloads exercise linkage and serialization, not HDR image interoperability. Local macOS static testing with lcms required explicitly linking lcms because of existing package metadata. Windows pkg-config integration and GN builds were not tested.