Repository navigation
Conversation
mingw32 fails during dependency installation because the pacboy GoogleTest package is unavailable. Use the existing pinned GoogleTest submodule for mingw32 while retaining system GoogleTest for other MSYS2 environments. The pinned Intel SDE 9.33 download no longer returns a usable archive, so x64 cross-test and AVX3 conformance jobs fail before executing tests. Update both download sites to 10.13.1, reject HTTP errors, and check the published SHA-256 before extracting downloaded or cached archives. Keep the existing test matrix and test-selection rules. Intel download and checksum: https://www.intel.com/content/www/us/en/download/684897/intel-software-development-emulator.html Validation: the old setup failures are reproduced in #2 . These exact workflow changes passed mingw32 compilation, x64 shards, and conformance in #1 . Normal PR runs compile mingw32 but skip its unit tests unless CI:full is set. Local ci.sh lint 15, source-list checks, YAML parsing, and git diff --check pass.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-only validation of the standalone CI repair commit before upstream submission. Results for this branch are pending.
Description
The mingw32 job fails while installing
mingw-w64-i686-gtest, which is no longer available. The x64 cross-test and AVX3 conformance jobs also fail before running tests because the pinned Intel SDE download no longer returns a usable archive.Use the existing GoogleTest submodule for mingw32 and keep system GoogleTest for the other MSYS2 environments. Update both SDE download sites to 10.13.1, verify the archive against Intel's published SHA-256, and make curl fail on HTTP errors.
The test matrix and test-selection rules are unchanged.
Testing
The same workflow changes passed in fork PR #1, including mingw32 compilation, all x64 test shards, and conformance. The original setup failures were reproduced in fork PR #2. Normal PR runs compile mingw32 but do not execute its unit tests unless
CI:fullis set.Pull Request Checklist
./ci.sh lint 15, YAML parsing, and whitespace checks pass. Optional buildifier, typos, and zizmor checks will run in CI.