Skip to content

fix crash when HMS error fires before device is registered (X2D) #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WrathPak wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

fix crash when HMS error fires before device is registered (X2D) #2019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions custom_components/bambu_lab/coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,6 +734,12 @@ def _update_data(self):
def _update_printer_error(self):
dev_reg = device_registry.async_get(self._hass)
hadevice = dev_reg.async_get_device(identifiers={(DOMAIN, self.get_model().info.serial)})
if hadevice is None:
# Device not in the registry yet (HMS error can arrive during the initial
# connect, before the device entry exists). Skip this cycle to avoid
# AttributeError on hadevice.id.
LOGGER.debug("_update_printer_error: device not registered yet, skipping")
return
device = self.get_model()
if device.hms.error_count == 0:
event_data = {
Expand All @@ -758,6 +764,9 @@ def _update_printer_error(self):
def _update_print_error(self):
dev_reg = device_registry.async_get(self._hass)
hadevice = dev_reg.async_get_device(identifiers={(DOMAIN, self.get_model().info.serial)})
if hadevice is None:
LOGGER.debug("_update_print_error: device not registered yet, skipping")
return

device = self.get_model()
if device.print_error.on == 0:
Expand Down