Code review Webdev@Uniandes 201614859#1
Open
sguzmanm wants to merge 16 commits intogregorioospina:masterfrom
Open
Code review Webdev@Uniandes 201614859#1sguzmanm wants to merge 16 commits intogregorioospina:masterfrom
sguzmanm wants to merge 16 commits intogregorioospina:masterfrom
Conversation
Good for not getting the user out of your webpage
Good for keeping your user inside the webpage
Good for keeping your users inside the webpage
sguzmanm
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Review
Hi Gregorio, this is your code review for the first proyect of the webdev class @ Uniandes. I liked your work. However I see three issues you should look into ASAP:
In general it is good, there are some issues I have with your coding style in HTML mostly and I loved the domain touch (.com).
Best regards,
Sergio Guzmán M.
201614859