Skip to content

style(biome): fix lint and formatting errors - #4

Merged
greythx merged 2 commits into
mainfrom
style/biome-formatting
Aug 12, 2026
Merged

style(biome): fix lint and formatting errors#4
greythx merged 2 commits into
mainfrom
style/biome-formatting

Conversation

@greythx

@greythx greythx commented Aug 12, 2026

Copy link
Copy Markdown
Owner

Resolves all 13 �iome check errors plus the schema-version info:\n\n- Apply biome formatter fixes (JSX prop wrapping, function-arg wrapping, dependency-array wrapping, expression wrapping) across components and config files.\n- Bump biome.json schema from 2.5.5 to 2.5.8 to match the installed CLI.\n\nVerification: \�un run lint, \�unx biome format ., \�un run build, and \�un run test\ (54 tests) all pass.

Copilot AI lite review requested due to automatic review settings August 12, 2026 21:15
@vercel

vercel Bot commented Aug 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
prophetly Ready Ready Preview Aug 12, 2026 9:15pm

@greythx
greythx merged commit 6d2760a into main Aug 12, 2026
3 checks passed
@greythx
greythx deleted the style/biome-formatting branch August 12, 2026 21:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies Biome-driven formatting updates across UI components and utility code to resolve lint/format errors, and updates the Biome JSON schema URL to match the installed CLI version.

Changes:

  • Reformat TS/TSX code (argument lists, JSX prop wrapping, dependency-array wrapping) to satisfy Biome checks.
  • Update biome.json $schema from 2.5.5 to 2.5.8.
  • Minor JSX wrapping changes across several components for consistent formatting.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/lib/cv-helper.ts Multi-line function signatures to satisfy formatter output.
src/components/ui/input.tsx Multi-line prop destructuring formatting for Input component.
src/components/theme-toggle.tsx Wrap ternary JSX to multi-line formatting.
src/components/stepper.tsx Multi-line JSX props formatting for icon rendering.
src/components/step-upload.tsx Multi-line JSX props formatting for icons and triggers.
src/components/step-results.tsx Multi-line JSX props and text wrapping in tabs/controls.
src/components/step-configure.tsx Wrap dependency arrays/function args and some JSX prop formatting.
src/components/loading-overlay.tsx Multi-line JSX props formatting for icons.
src/components/history-sheet.tsx Multi-line JSX props formatting for icons.
src/components/cv-config-dialog.tsx Multi-line arg wrapping and label formatting (note: introduced JSX whitespace issue).
src/components/configure-sections.tsx Multi-line JSX props and label formatting (note: introduced JSX whitespace issue).
biome.json Bump schema URL version to 2.5.8.
Suppressed comments (4)

src/components/cv-config-dialog.tsx:218

  • JSX line break between "(" and the percentage expression will render a whitespace character inside the parentheses (e.g., "( 20%)"). Keep the "(" adjacent to the expression to preserve the original label formatting.
                <span className="font-mono text-muted-foreground tabular-nums">
                  {split.horizonLabel || split.horizonStr} (
                  {(split.horizonPct * 100).toFixed(0)}%)
                </span>

src/components/cv-config-dialog.tsx:239

  • JSX line break between "(" and the percentage expression will render a whitespace character inside the parentheses. Keep the "(" adjacent to the expression to avoid changing the displayed text.
                <span className="font-mono text-muted-foreground tabular-nums">
                  {split.periodLabel || split.periodStr} (
                  {(split.periodPct * 100).toFixed(0)}%)
                </span>

src/components/configure-sections.tsx:402

  • JSX line break between "(" and the percentage expression will render a whitespace character inside the parentheses. Keep the "(" adjacent to the expression to avoid changing the displayed text.
            <span className="font-mono text-muted-foreground text-[11px] tabular-nums">
              {cvSplit.horizonLabel || cvSplit.horizonStr} (
              {(cvSplit.horizonPct * 100).toFixed(0)}%)
            </span>

src/components/configure-sections.tsx:422

  • JSX line break between "(" and the percentage expression will render a whitespace character inside the parentheses. Keep the "(" adjacent to the expression to preserve the original label formatting.
            <span className="font-mono text-muted-foreground text-[11px] tabular-nums">
              {cvSplit.periodLabel || cvSplit.periodStr} (
              {(cvSplit.periodPct * 100).toFixed(0)}%)
            </span>

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines 194 to 197
<span className="font-mono text-muted-foreground tabular-nums">
{split.initialLabel || split.initialStr} ({(split.initialPct * 100).toFixed(0)}%)
{split.initialLabel || split.initialStr} (
{(split.initialPct * 100).toFixed(0)}%)
</span>
Comment on lines 379 to 382
<span className="font-mono text-muted-foreground text-[11px] tabular-nums">
{cvSplit.initialLabel || cvSplit.initialStr} ({(cvSplit.initialPct * 100).toFixed(0)}%)
{cvSplit.initialLabel || cvSplit.initialStr} (
{(cvSplit.initialPct * 100).toFixed(0)}%)
</span>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants