fix(biome): stabilize LF line endings with .gitattributes - #5
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds repository-level Git line-ending normalization to prevent Biome lint/format failures caused by CRLF checkouts when core.autocrlf=true.
Changes:
- Introduces a
.gitattributesrule to enforce LF (* text=auto eol=lf) across checkouts/clones.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -0,0 +1 @@ | |||
| * text=auto eol=lf No newline at end of file | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the post-merge lint regression.
Problem: After the formatting PR merged,
core.autocrlf=truerewrote working-tree files to CRLF on checkout, but biome.json mandateslineEnding: "lf", sobun run lintfailed again on 12 files.Fix: Commit a
.gitattributes(* text=auto eol=lf) so every checkout/clone yields LF regardless of autocrlf — verified with a fresh local clone (0 CRLF). Full verification green: lint, format, build, 54 tests.