Whitelist: color and sort "Active by Greylist Override" as active - #451
Merged
barton2526 merged 1 commit intoJun 2, 2026
Merged
Conversation
The status column previously fell through projectStatus()'s default
branch for "Active by Greylist Override", which left cssClass empty
and routed the badge to the danger (red) case — visually grouping
override rows with greylisted ones even though they are in the
superblock and earning rewards.
Treat the override status as a member of the active category:
- projectStatus() returns cssClass "status-active" for it (keeping
the distinct display label so the override is still visible).
- The badge-color check now keys off cssClass rather than the raw
display text, so the semantic category drives the color.
- sortOrder gains an entry between "Active" and "Excluded" so
override rows sort with the active group, not at the bottom.
Drive-by: sortOrder[x] || 9 collapsed 0 (Active's ordinal) to 9 via
JS falsiness, so plain-Active rows were also sorting to the bottom.
Use ?? instead. Not visible today because every active project on
the live whitelist is currently flagged as override.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Active by Greylist Overridewas rendering red — it fell throughprojectStatus()'s default branch (emptycssClass) and the badge-color check routed anything not literallyActiveorExcludedtodanger. Override projects are in the superblock and earning rewards, so they should read as active, not greylisted.projectStatus()now returnscssClass: "status-active"for the override status (keeping the distinct display label so the override is still visible under the project name). The badge-color check now keys offcssClassrather than the raw display text, so the semantic category drives the color.sortOrdergains an entry betweenActiveandExcludedso override rows sort with the active group, ahead of greylisted rows.sortOrder[x] || 9collapsed0(Active's ordinal) to9via JS falsiness —??instead. Not visible today because every active project on the live whitelist is currently flagged as override, but would surface as soon as any plain-Active project appeared.Test plan
http://jco-linux.jcowens.net:81/whitelist.htm: override rows render with a greenbg-successbadge and sort within the active group, ahead of greylisted rows.🤖 Generated with Claude Code